[FreshEyes] Prune locks#12
Open
adamjonas wants to merge 10 commits intobitcoin-fresheyes-staging-master-19463from
Open
[FreshEyes] Prune locks#12adamjonas wants to merge 10 commits intobitcoin-fresheyes-staging-master-19463from
adamjonas wants to merge 10 commits intobitcoin-fresheyes-staging-master-19463from
Conversation
Including desc member of PruneLockInfo for a human-readable description
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
![fresheyes-staging-bot[bot]](https://avatars.githubusercontent.com/in/855196?s=60&v=4){kind=small}
|
This is an OUTDATED review comment as the original pull request may have been rebased or force-pushed
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
|
An author commented here with:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The author luke-jr wrote the following PR called Prune locks, issue number 19463 in bitcoin/bitcoin cloned by FreshEyes below:
This adds the ability to have any number of internal or external locks to prevent pruning specific block ranges.
Some examples where this would be useful:
By design, users retain complete control over prune locks, and can delete them out from under applications using them. This is to avoid circumstances where a prune lock has been set, by an application that may no longer be used.